ffi: expose array validity, allow creating primitive arrays#7148
Merged
ffi: expose array validity, allow creating primitive arrays#7148
Conversation
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
b7d2f79 to
516884b
Compare
myrrc
added
changelog/feature
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
516884b to
430ec1e
Compare
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
430ec1e to
a3c15ad
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
0ax1
reviewed
Mar 25, 2026
0ax1
reviewed
Mar 25, 2026
Contributor
0ax1
left a comment
0ax1
left a comment
There was a problem hiding this comment.
We need to double check the consistency of size types for indices:
vx_array_get_field` | `uint32_t` |
| `vx_array_slice` | `uint32_t` |
| `vx_array_get_u8` etc. | `uint32_t` |
| `vx_array_null_count` return | `uint32_t
should prob all be size_t.
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
a3c15ad to
353e971
Compare
myrrc
added a commit
that referenced
this pull request
Mar 30, 2026
Expose a subset of expressions to test filtering in Scan API: root, column, get_item, select, or, not, is_null, and binary operators, including shortcuts like eq. Add vx_array_apply to test C-side expression application. This patch does not include C++ FFI tests because we can't create vx_arrays' yet, #7148. The next steps are exposing literal expressions and dynamic expressions. Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
5 times, most recently
from
7b4b232 to
e564354
Compare
0ax1
reviewed
Mar 31, 2026
0ax1
reviewed
Mar 31, 2026
0ax1
reviewed
Mar 31, 2026
0ax1
reviewed
Mar 31, 2026
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
2 times, most recently
from
2f7fff8 to
69de977
Compare
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
69de977 to
e18ed69
Compare
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
e18ed69 to
58228bb
Compare
0ax1
reviewed
Apr 1, 2026
0ax1
reviewed
Apr 1, 2026
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com> Signed-off-by: Mikhail Kot <to@myrrc.dev>
myrrc
force-pushed
the
myrrc/primitive-ffi
branch
from
58228bb to
b8e9b2a
Compare
0ax1
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
directly instead of array -> dtype -> variant [-> ptype] chain.
Breaking changes:
vx_array_is_nulltovx_array_element_is_invalid.vx_array_null_counttovx_array_invalid_count.